Skip to content

(feat): [AILIKFD-40] add kfdtest to TheRock CI#6334

Open
andmar-amd wants to merge 1 commit into
mainfrom
users/andmar-amd/kfdtest
Open

(feat): [AILIKFD-40] add kfdtest to TheRock CI#6334
andmar-amd wants to merge 1 commit into
mainfrom
users/andmar-amd/kfdtest

Conversation

@andmar-amd

Copy link
Copy Markdown
Contributor

Re-landing kfdtest integration after runtime ASAN fix.

JIRA ID: AILIKFD-40

Co-Authored-By: Claude Sonnet 4.5

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/install_rocm_from_artifacts.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 3, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Comment thread core/CMakeLists.txt
Comment thread core/CMakeLists.txt
Comment thread core/CMakeLists.txt
run
test
SUBPROJECT_DEPS
kfdtest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this depend on anything else other than itself?

Comment thread BUILD_TOPOLOGY.toml Outdated
Comment thread core/artifact-core-kfdtest.toml
- Add kfdtest subproject with correct dependencies (statically links libhsakmt and LLVM)
- Add --kfdtest flag to install_rocm_from_artifacts.py
- Add kfdtest to BUILD_TOPOLOGY.toml (artifact group, build stage, and artifact)
- Add sysdeps to kfdtest artifact dependencies for bundled libraries
- Use get_target_property to dynamically locate ROCR-Runtime binary directory
- Set RPATH to lib/rocm_sysdeps/lib only (kfdtest statically links main deps)

JIRA ID: AILIKFD-40

Co-Authored-By: Claude Sonnet 4.5
Signed-off-by: Andrew Martin <andrew.martin@amd.com>
@andmar-amd andmar-amd force-pushed the users/andmar-amd/kfdtest branch from a43a8be to 2d97e92 Compare July 7, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants